Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix raven-wps CLI entrypoint #475

Merged
merged 6 commits into from
May 17, 2023
Merged

Fix raven-wps CLI entrypoint #475

merged 6 commits into from
May 17, 2023

Conversation

Zeitsperre
Copy link
Contributor

@Zeitsperre Zeitsperre commented May 15, 2023

Overview

This PR fixes #472

Changes:

  • Modified entrypoint to use raven-wps
  • use python3 calls for compatibility (macOS and Linux)
  • Updates the methods for fetching remote JSON files to be read by GeoPandas (with pyogrio)

Related Issue / Discussion

Additional Information

The only test presently failing is due to the breaking changes in GeoPandas (also seen here: CSHS-CWRA/RavenPy#278 (comment))

  • Resolved.

@Zeitsperre Zeitsperre added bug Something isn't working Ouranos labels May 15, 2023
@Zeitsperre Zeitsperre self-assigned this May 15, 2023
@Zeitsperre Zeitsperre requested review from huard and tlvu May 15, 2023 15:41
@Zeitsperre
Copy link
Contributor Author

Zeitsperre commented May 15, 2023

@huard Questions for you:

@Zeitsperre Zeitsperre merged commit 734751f into master May 17, 2023
@Zeitsperre Zeitsperre deleted the pyproject_fixes branch May 17, 2023 20:10
Zeitsperre added a commit that referenced this pull request Aug 17, 2023
## Overview

This PR fixes #472 

Changes:

* Modified entrypoint to use raven-wps
* use `python3` calls for compatibility (macOS and Linux)
* Updates the methods for fetching remote JSON files to be read by
GeoPandas (with pyogrio)

## Related Issue / Discussion

CSHS-CWRA/RavenPy#278 (comment))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Ouranos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs refer to raven-wps executable, which is not created by toml config
2 participants